Add lookup fallback to t! #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huacnlee
reviewed
Jan 15, 2024
| let mut current_locale = locale; | ||
| while let Some(fallback_locale) = _rust_i18n_lookup_fallback(current_locale) { | ||
| if let Some(value) = _RUST_I18N_BACKEND.translate(fallback_locale, key) { | ||
| return value.to_string(); |
There was a problem hiding this comment.
哦，这个仅是 fallback 的时候才会触发，还好。你试试看 to_string 能否避免，如果可以那就减少一次创建 String，不行的话也可以的。
There was a problem hiding this comment.
不行，translate() 返回的是 Option<&str>，而 _rust_i18n_translate() 返回的是 String。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lookup fallback to t!
Example of a Lookup Fallback Pattern
Range to match: zh-Hant-CN-x-private1-private2
Closed: #67